Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-31 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: Markus Armbruster a écrit : Hervé Poussineau writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Yes.

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-31 Thread Markus Armbruster
Hervé Poussineau writes: > Markus Armbruster a écrit : >> Hervé Poussineau writes: >> >>> DIR and CCR registers share the same address ; DIR is read-only >>> while CCR is write-only >> >> Looks like guest writes to CCR are silently ignored before this patch. >> Is that correct? > > Yes. > >> I

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-27 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Yes. Impact? CCR is only used to program media rate, wh

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-27 Thread Markus Armbruster
Hervé Poussineau writes: > DIR and CCR registers share the same address ; DIR is read-only > while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Impact?

[Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-23 Thread Hervé Poussineau
DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Signed-off-by: Hervé Poussineau --- hw/fdc.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 4a363bd..4875291 100644 --- a/hw/fdc.c +++