Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-04-18 Thread Wei Yang
On Thu, Apr 18, 2019 at 01:02:41PM +0200, Igor Mammedov wrote: >On Wed, 17 Apr 2019 09:40:38 +0800 >Wei Yang wrote: > >> build_append_foo() API doesn't need explicit endianness conversions >> which eliminates a source of errors and it makes build_mcfg() look like >> declarative definition of MCFG

Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-04-18 Thread Philippe Mathieu-Daudé
On 4/18/19 1:02 PM, Igor Mammedov wrote: > On Wed, 17 Apr 2019 09:40:38 +0800 > Wei Yang wrote: > >> build_append_foo() API doesn't need explicit endianness conversions >> which eliminates a source of errors and it makes build_mcfg() look like >> declarative definition of MCFG table in ACPI spec,

Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-04-18 Thread Igor Mammedov
On Wed, 17 Apr 2019 09:40:38 +0800 Wei Yang wrote: > build_append_foo() API doesn't need explicit endianness conversions > which eliminates a source of errors and it makes build_mcfg() look like > declarative definition of MCFG table in ACPI spec, which makes it easy > to review. > > Signed-off-

[Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG

2019-04-16 Thread Wei Yang
build_append_foo() API doesn't need explicit endianness conversions which eliminates a source of errors and it makes build_mcfg() look like declarative definition of MCFG table in ACPI spec, which makes it easy to review. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov --- hw/acpi/pci.c