Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
> > > static void uhci_reset(void *opaque) > > > @@ -1240,8 +1239,7 @@ static int usb_uhci_common_initfn(PCIDevice *dev) > > > /* TODO: reset value should be 0. */ > > > pci_conf[USB_SBRN] = USB_RELEASE_1; // release number > > > > > > -s->irq_pin = u->info.irq_pin; > > > -pci

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 11:03:47AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: > > pci_set_irq and the other pci irq wrappers use > > PCI_INTERRUPT_PIN config register to compute device > > INTx pin to assert/deassert. > > > > An irq is allo

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: > pci_set_irq and the other pci irq wrappers use > PCI_INTERRUPT_PIN config register to compute device > INTx pin to assert/deassert. > > An irq is allocated using pci_allocate_irq wrapper > only if is needed by non pci devices. >

[Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices. Removed irq related fields from state if not used anymore. Signed-off-by: Marce