Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread James Hogan
Hi Andreas, On 13/03/14 21:28, Andreas Färber wrote: diff --git a/target-mips/kvm.c b/target-mips/kvm.c new file mode 100644 index 000..0ec343d --- /dev/null +++ b/target-mips/kvm.c [...] +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int32 *addr) Did you mean

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread James Hogan
On 13/03/14 22:35, Peter Maydell wrote: On 13 March 2014 21:28, Andreas Färber afaer...@suse.de wrote: I'm not sure if we have a policy about __u64 etc. in KVM code. Since it'll be Linux-only I don't see problems currently; for cross-platform parts we prefer uint64_t. Suggest to leave as is

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-14 Thread Paolo Bonzini
Il 13/03/2014 23:35, Peter Maydell ha scritto: I'm not sure if we have a policy about __u64 etc. in KVM code. Since it'll be Linux-only I don't see problems currently; for cross-platform parts we prefer uint64_t. Suggest to leave as is unless told otherwise. For ARM I took the view that

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-13 Thread Andreas Färber
Am 06.03.2014 18:09, schrieb James Hogan: From: Sanjay Lal sanj...@kymasys.com Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal sanj...@kymasys.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Gleb Natapov

Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-13 Thread Peter Maydell
On 13 March 2014 21:28, Andreas Färber afaer...@suse.de wrote: int32 is a type used in softfloat that has weird at-least-as-wide semantics and bit us in the past. I'm coming round to the opinion that we should just change all those to int32_t c. I know we had a discussion about efficiency at

[Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS

2014-03-06 Thread James Hogan
From: Sanjay Lal sanj...@kymasys.com Implement the main KVM arch API for MIPS. Signed-off-by: Sanjay Lal sanj...@kymasys.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Aurelien Jarno aurel...@aurel32.net Cc: Gleb Natapov g...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: