Re: [Qemu-devel] [PATCH v3 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr

2014-06-06 Thread Stefan Hajnoczi
On Fri, Jun 06, 2014 at 09:53:27AM +0800, Fam Zheng wrote: @@ -200,17 +193,12 @@ static int process_request(VirtIOBlockDataPlane *s, VirtQueueElement *elem) } iov_discard_front(iov, out_num, sizeof(outhdr)); +/* This is always true because it is only 1 byte, but checked here

[Qemu-devel] [PATCH v3 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr

2014-06-05 Thread Fam Zheng
In current virtio spec, inhdr is a single byte, and is unlikely to change for both functionality and compatibility considerations. Non-dataplane uses .in, and we are on the way to converge them. So let's unify it to get cleaner code. Remove .inhdr and use .in. Signed-off-by: Fam Zheng