Re: [Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-05-31 Thread Eduardo Habkost
On Wed, May 31, 2017 at 10:50:27AM +0200, Igor Mammedov wrote: > On Tue, 30 May 2017 17:03:32 -0300 > Eduardo Habkost wrote: > > > On Tue, May 30, 2017 at 06:24:02PM +0200, Igor Mammedov wrote: > [...] > > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > > index 76ce021..063f329 10064

Re: [Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-05-31 Thread Igor Mammedov
On Tue, 30 May 2017 17:03:32 -0300 Eduardo Habkost wrote: > On Tue, May 30, 2017 at 06:24:02PM +0200, Igor Mammedov wrote: [...] > > diff --git a/include/hw/boards.h b/include/hw/boards.h > > index 76ce021..063f329 100644 > > --- a/include/hw/boards.h > > +++ b/include/hw/boards.h > > @@ -94,6 +9

Re: [Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-05-30 Thread Eduardo Habkost
On Tue, May 30, 2017 at 06:24:02PM +0200, Igor Mammedov wrote: > Calculating default node-ids for CPUs in possible_cpu_arch_ids() > is rather fragile since defaults calculation uses nb_numa_nodes but > callback might be potentially called early before all -numa CLI > options are parsed, which would

[Qemu-devel] [PATCH v3 7/7] numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed

2017-05-30 Thread Igor Mammedov
Calculating default node-ids for CPUs in possible_cpu_arch_ids() is rather fragile since defaults calculation uses nb_numa_nodes but callback might be potentially called early before all -numa CLI options are parsed, which would lead to cpus assigned only upto nb_numa_nodes at the time possible_cpu