Re: [Qemu-devel] [PATCH v3 8/9] jobs: remove ret argument to job_completed; privatize it

2018-08-31 Thread Max Reitz
On 2018-08-30 03:57, John Snow wrote: > Jobs are now expected to return their retcode on the stack, from the > .run callback, so we can remove that argument. > > job_cancel does not need to set -ECANCELED because job_completed will > update the return code itself if the job was canceled. > > Whil

[Qemu-devel] [PATCH v3 8/9] jobs: remove ret argument to job_completed; privatize it

2018-08-29 Thread John Snow
Jobs are now expected to return their retcode on the stack, from the .run callback, so we can remove that argument. job_cancel does not need to set -ECANCELED because job_completed will update the return code itself if the job was canceled. While we're here, make job_completed static to job.c and