Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 11:35:37AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 10:03:41AM +0200, BALATON Zoltan wrote: > > > On Thu, 14 Jun 2018, David Gibson wrote: > > > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > >

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-15 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 10:03:41AM +0200, BALATON Zoltan wrote: On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Maybe amend commit message like this: According to PPC440 User Manual On which

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-14 Thread David Gibson
On Thu, Jun 14, 2018 at 10:03:41AM +0200, BALATON Zoltan wrote: > On Thu, 14 Jun 2018, David Gibson wrote: > > On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > > Maybe amend commit message like this: > > According to PPC440 User Manual On which page? Where can I get that

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Maybe amend commit message like this: According to PPC440 User Manual PPC440 has two opcodes for icbt, add the missing one. If you can do this when committing then please feel free to

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-13 Thread David Gibson
On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: > PPC440 has two opcodes for icbt, add the missing one. A document reference to confim this would be nice. > Signed-off-by: BALATON Zoltan > --- > target/ppc/translate.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-13 Thread BALATON Zoltan
PPC440 has two opcodes for icbt, add the missing one. Signed-off-by: BALATON Zoltan --- target/ppc/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 5fe1ba6..3a215a1 100644 --- a/target/ppc/translate.c +++