[Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Laszlo Ersek
v2-v3 [Paolo]: - The memory API guarantees an increasing traversal. Drop the hash tables and build the final list directly in the region_add callback, merging any adjacent region only with the last element on the list. (Patch #3.) When dumping a 3700 MB guest, the following messages were

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Paolo Bonzini
v2-v3 [Paolo]: - The memory API guarantees an increasing traversal. Drop the hash tables and build the final list directly in the region_add callback, merging any adjacent region only with the last element on the list. (Patch #3.) I only looked at this change, it looks good. Thanks

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Luiz Capitulino
On Tue, 6 Aug 2013 12:37:07 +0200 Laszlo Ersek ler...@redhat.com wrote: v2-v3 [Paolo]: - The memory API guarantees an increasing traversal. Drop the hash tables and build the final list directly in the region_add callback, merging any adjacent region only with the last element on the

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Laszlo Ersek
On 08/06/13 22:13, Luiz Capitulino wrote: On Tue, 6 Aug 2013 12:37:07 +0200 Laszlo Ersek ler...@redhat.com wrote: v2-v3 [Paolo]: - The memory API guarantees an increasing traversal. Drop the hash tables and build the final list directly in the region_add callback, merging any adjacent