Re: [Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-15 Thread Aurelien Jarno
On 2017-07-11 08:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > v3.5: Added even register checks in the translator [thuth]. > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/tran

Re: [Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-12 Thread Richard Henderson
On 07/11/2017 08:46 PM, Thomas Huth wrote: +s1 = cpu_ldub_data_ra(env, addr + 1, ra); +s2 = cpu_ldub_data_ra(env, addr + 2, ra); +c = s0 & 0x0f; +c = (c << 6) | (s1 & 0x3f); +c = (c << 6) | (s2 & 0x3f); +/* Fold the byte-by-byte range descriptions i

Re: [Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-11 Thread Thomas Huth
On 11.07.2017 20:23, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > v3.5: Added even register checks in the translator [thuth]. > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/tran

[Qemu-devel] [PATCH v3.5 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v3.5: Added even register checks in the translator [thuth]. --- target/s390x/helper.h | 6 + target/s390x/mem_helper.c | 310 + target/s390x/translate.c | 51 target/s390x/insn-data.def | 13 ++