Re: [Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-06-12 Thread Richard Henderson
On 06/04/2018 06:46 AM, Peter Maydell wrote: >> +do_clast_scalar(s, a->esz, a->pg, a->rn, before, cpu_reg(s, a->rd)); > > Why do we use cpu_reg() again here rather than just using 'reg' ? Fixed. r~

Re: [Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 11 ++ > target/arm/translate-sve.c | 318 + > target/arm/sve.decode | 20 +++ > 4 files chan

[Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 11 ++ target/arm/translate-sve.c | 318 + target/arm/sve.decode | 20 +++ 4 files changed, 351 insertions(+) diff --git a/target/arm/helper-sve.h b/ta