Re: [Qemu-devel] [PATCH v3b 15/18] target/arm: Implement SVE Integer Compare - Scalars Group

2018-06-12 Thread Richard Henderson
On 06/05/2018 08:02 AM, Peter Maydell wrote: >> +if (count & 63) { >> +d->p[i] = ~(-1ull << (count & 63)) & esz_mask; > > Is this d->p[i] = MAKE_64BIT_MASK(0, count & 63) & esz_mask; ? Fixed. >> +tcg_gen_setcond_i64(cond, cmp, rn, rm); >> +tcg_gen_extrl_i64_i32(cpu_NF, cmp);

Re: [Qemu-devel] [PATCH v3b 15/18] target/arm: Implement SVE Integer Compare - Scalars Group

2018-06-05 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 31 +++ > target/arm/translate-sve.c | 102 + > target/arm/sve.decode | 8 +++ > 4 f

[Qemu-devel] [PATCH v3b 15/18] target/arm: Implement SVE Integer Compare - Scalars Group

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 31 +++ target/arm/translate-sve.c | 102 + target/arm/sve.decode | 8 +++ 4 files changed, 143 insertions(+) diff --git a/target/arm/helper-s