Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-26 Thread Dou Liyang
Deer Eduardo, At 10/26/2017 04:02 PM, Eduardo Habkost wrote: Hi, Sorry for taking so long to review it: Not matter. It's my honor! On Mon, Oct 23, 2017 at 09:33:42AM +0800, Dou Liyang wrote: [...] + */ +if (ram_slots > 0 && QTAILQ_EMPTY(_opts->head)) { +if

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-26 Thread Eduardo Habkost
Hi, Sorry for taking so long to review it: On Mon, Oct 23, 2017 at 09:33:42AM +0800, Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-23 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly === TEST SCRIPT BEGIN === #!/bin/bash # Testing script

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-23 Thread Fam Zheng
talled, you can probably > > reproduce it > > locally. > > > > Type: series > > Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com > > Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly > > > > === TEST SCRIPT BE

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
Hi, Fam At 10/23/2017 09:37 AM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 time make docker

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1508722422-3861-1-git-send-email-douly.f...@cn.fujitsu.com Subject: [Qemu-devel] [PATCH v4] NUMA

[Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-22 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all