Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-07 Thread Stefano Stabellini
On Thu, 7 Jan 2016, Gerd Hoffmann wrote: > On Do, 2016-01-07 at 15:01 +, Stefano Stabellini wrote: > > Your patch is simpler and more mature. Maybe it should go in before Gerd's > > series? > > My series would throw away most of the error handling fixes here, so > IMHO that would be pointless

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Lars Kurth
On 04/01/2016 14:47, "Stefano Stabellini" wrote: >Unfortunately I don't have a setup to test this either. Maybe Lars can >find out who should be involved on the Intel side on this. I can certainly help to this and get back to you. What exactly are we asking Intel to do? It is not clear to me f

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Stefano Stabellini
On Mon, 4 Jan 2016, Lars Kurth wrote: > On 04/01/2016 14:47, "Stefano Stabellini" > wrote: > > >Unfortunately I don't have a setup to test this either. Maybe Lars can > >find out who should be involved on the Intel side on this. > > I can certainly help to this and get back to you. What exactly

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-04 Thread Stefano Stabellini
Unfortunately I don't have a setup to test this either. Maybe Lars can find out who should be involved on the Intel side on this. In any case, the patch looks good to me. It would be nice to get feedback from somebody at Intel before applying it, but if we don't get any to your next version of the

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Cao jin
Agree with your review point. Since can`t get contact with author tiejun.c...@intel.com, maybe only can ask for test help from Stefano, I will send next version when we get in touch with stefano. On 12/29/2015 07:25 PM, Michael S. Tsirkin wrote: On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao ji

Re: [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Michael S. Tsirkin
On Tue, Dec 29, 2015 at 04:46:03PM +0800, Cao jin wrote: > Signed-off-by: Cao jin > --- > changelog v4: > 1. strip the bugfix code, but I guess this patch should be applied after >that bugfix patch. > 2. Other little fix as per previous review > > Some explanation to previous review: > 1. err

[Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2015-12-29 Thread Cao jin
Signed-off-by: Cao jin --- changelog v4: 1. strip the bugfix code, but I guess this patch should be applied after that bugfix patch. 2. Other little fix as per previous review Some explanation to previous review: 1. error_setg_errno() I use in this patch will print the strerror(errno), so I