Re: [Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

2018-04-09 Thread Max Filippov
On Mon, Apr 9, 2018 at 5:23 PM, Richard Henderson wrote: > On 04/06/2018 11:36 AM, Max Filippov wrote: >> +static void target_to_host_low_high(abi_ulong tlow, >> +abi_ulong thigh, >> +unsigned long *hlow, >> +

Re: [Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

2018-04-09 Thread Richard Henderson
On 04/06/2018 11:36 AM, Max Filippov wrote: > +static void target_to_host_low_high(abi_ulong tlow, > +abi_ulong thigh, > +unsigned long *hlow, > +unsigned long *hhigh) > +{ > +unsigned lo

Re: [Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

2018-04-09 Thread Laurent Vivier
Le 06/04/2018 à 03:36, Max Filippov a écrit : > preadv/pwritev accept low and high parts of file offset in two separate > parameters. When host bitness doesn't match guest bitness these parts > must be appropriately recombined. > Introduce target_to_host_low_high that does this recombination and us

[Qemu-devel] [PATCH v4] linux-user: fix preadv/pwritev offsets

2018-04-05 Thread Max Filippov
preadv/pwritev accept low and high parts of file offset in two separate parameters. When host bitness doesn't match guest bitness these parts must be appropriately recombined. Introduce target_to_host_low_high that does this recombination and use it in preadv/pwritev syscalls. This fixes glibc tes