Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-11-05 Thread Mao Zhongyi
On 11/03/2017 11:10 PM, Stefan Hajnoczi wrote: On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote: On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote: On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: ioh3420_interrupts_init() pass error message to local_err, then propagate

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-11-03 Thread Stefan Hajnoczi
On Thu, Oct 12, 2017 at 10:44:26AM +0800, Mao Zhongyi wrote: > On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote: > > On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: > > > ioh3420_interrupts_init() pass error message to local_err, then > > > propagate it to errp by error_propagate(),

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-10-11 Thread Mao Zhongyi
On 09/12/2017 06:16 PM, Stefan Hajnoczi wrote: On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: ioh3420_interrupts_init() pass error message to local_err, then propagate it to errp by error_propagate(), which is not necessary. So eliminate it and pass errp directly instead of

Re: [Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-09-12 Thread Stefan Hajnoczi
On Sat, Sep 09, 2017 at 02:22:26PM +0800, Mao Zhongyi wrote: > ioh3420_interrupts_init() pass error message to local_err, then > propagate it to errp by error_propagate(), which is not necessary. > So eliminate it and pass errp directly instead of local_err. > > Cc: "Michael S. Tsirkin"

[Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-09-09 Thread Mao Zhongyi
ioh3420_interrupts_init() pass error message to local_err, then propagate it to errp by error_propagate(), which is not necessary. So eliminate it and pass errp directly instead of local_err. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Signed-off-by: Mao