On Tue, Sep 30, 2014 at 08:23:05AM +, Gonglei (Arei) wrote:
> > Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> > message
> >
> > Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > > error_report() is just fine here. qerr
> Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error
> message
>
> Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> > error_report() is just fine here. qerror_report() is never necessary in
> > HMP-only code. It makes a difference only
Il 30/09/2014 10:12, Markus Armbruster ha scritto:
> error_report() is just fine here. qerror_report() is never necessary in
> HMP-only code. It makes a difference only in QMP context, and even
> there it should only be used in code that hasn't been converted to the
> Error API. For an example,
Paolo Bonzini writes:
> Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
>> we will lose the error message. Using error_report
>> to report it.
>>
>> Cc: Markus Armbruster
>> Signed-off-by: Gonglei
>> Reviewed-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> v4:
>> fix typ
Hi,
> Subject: Re: [PATCH v4] pci-hotplug-old: avoid losing error message
>
> Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
> > we will lose the error message. Using error_report
> > to report it.
> >
> > Cc: Markus Armbruster
> > Signed-off-by: Gonglei
> > Reviewed-by: Markus Armbru
Il 18/09/2014 15:06, arei.gong...@huawei.com ha scritto:
> we will lose the error message. Using error_report
> to report it.
>
> Cc: Markus Armbruster
> Signed-off-by: Gonglei
> Reviewed-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> v4:
> fix typo in the subject (Eric), Thanks.
> v
Hi, Michael
Would you like to pick up this patch, which had
been reviewed by Markus and Eric?
Thanks. :)
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, September 18, 2014 9:06 PM
> To: qemu-devel@nongnu.org
> Cc: m...@redhat.com; Huangweidong (C);
From: Gonglei
When scsi_bus_legacy_add_drive() produces an error,
we will lose the error message. Using error_report
to report it.
Cc: Markus Armbruster
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Reviewed-by: Eric Blake
---
v4:
fix typo in the subject (Eric), Thanks.
v3:
fix som
