Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Thu, Mar 17, 2016 at 11:50:15PM +0100, Paolo Bonzini wrote: > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi > > wrote: > > > > On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > >

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini wrote: > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi > > wrote: > > > > On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > > > @@ -17

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 3:05 PM, Stefan Hajnoczi wrote: > On Thu, Mar 17, 2016 at 11:50:15PM +0100, Paolo Bonzini wrote: > > > > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi > > > wrote: > > > > > >

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 6:59 PM, Jaya Tiwari wrote: > > On Fri, Mar 18, 2016 at 6:57 PM, Jaya Tiwari > wrote: > >> >> >> On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini >> wrote: >> >>> >>> >>> On 18/03/2016 12:24, Pooja Dhannawat wrote: >>> > >>> > >>> > On Fri, Mar 18, 2016 at 4:20 AM, Paolo B

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi > wrote: > > On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > > @@ -170,8 +170,8 @@ static void net_socket_send(void *opaque) > >

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On 18/03/2016 12:24, Pooja Dhannawat wrote: > > > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > wrote: > > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Thu, Mar 17, 2016 at 8:20 PM, Stefan Hajnoczi wrote: > On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > > @@ -170,8 +170,8 @@ static void net_socket_send(void *opaque) > > s->index = 0; > > s->packet_len = 0; > > s->nc.link_down = true; > > -

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Tue, Mar 15, 2016 at 09:29:58PM +0530, Pooja Dhannawat wrote: > @@ -170,8 +170,8 @@ static void net_socket_send(void *opaque) > s->index = 0; > s->packet_len = 0; > s->nc.link_down = true; > -memset(s->buf, 0, sizeof(s->buf)); This change is unrelated to alloc

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On 18/03/2016 14:49, Pooja Dhannawat wrote: > > > If it is greater than the accepted level, the on-stack > buffer is not > used and you allocate one that has the right size on the heap. > > Yes Okay. Thank you for the comments. > I had one mo

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini wrote: > > > On 18/03/2016 12:24, Pooja Dhannawat wrote: > > > > > > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > > wrote: > > > > > > > > On 17/03/2016 16:31, Pooja Dhannawat wrote: > > > > > > > > >

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Friday, March 18, 2016, Paolo Bonzini wrote: > > > On 18/03/2016 14:49, Pooja Dhannawat wrote: >> >> >> If it is greater than the accepted level, the on-stack >> buffer is not >> used and you allocate one that has the right size on the heap. >> >> Yes

Re: [Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

On Fri, Mar 18, 2016 at 6:57 PM, Jaya Tiwari wrote: > > > On Fri, Mar 18, 2016 at 5:21 PM, Paolo Bonzini > wrote: > >> >> >> On 18/03/2016 12:24, Pooja Dhannawat wrote: >> > >> > >> > On Fri, Mar 18, 2016 at 4:20 AM, Paolo Bonzini > > > wrote: >> > >> > >> > >> >

[Qemu-devel] [PATCH v4] socket: Allocating Large sized arrays to heap

net_socket_send has a huge stack usage of 69712 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Pooja Dhannawat --- net/socket.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/socket.c b/net/socket.c index e32e3cb..fd7f39f 100644 -