Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-26 Thread Rashmica Gupta
On Fri, 2019-08-16 at 18:21 +0200, Cédric Le Goater wrote: > On 16/08/2019 09:32, Rashmica Gupta wrote: > > v5: > > - integrated AspeedGPIOController fields into AspeedGPIOClass > > - separated ast2600_3_6v and ast2600_1_8v into two classes > > Rashmica, > > This looks much nicer ! > > Please

Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-16 Thread Cédric Le Goater
On 16/08/2019 09:32, Rashmica Gupta wrote: > v5: > - integrated AspeedGPIOController fields into AspeedGPIOClass > - separated ast2600_3_6v and ast2600_1_8v into two classes Rashmica, This looks much nicer ! Please take a look at branch aspeed-4.2 in which I have merged your v5 and modified

[Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-16 Thread Rashmica Gupta
v5: - integrated AspeedGPIOController fields into AspeedGPIOClass - separated ast2600_3_6v and ast2600_1_8v into two classes v4: - proper interupt handling thanks to Andrew - switch statements for reading and writing suggested by Peter - some small cleanups suggested by Alexey v3: - didn't have

Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190814071433.22243-1-rashmic...@gmail.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit

[Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-14 Thread Rashmica Gupta
v4: - proper interupt handling thanks to Andrew - switch statements for reading and writing suggested by Peter - some small cleanups suggested by Alexey v3: - didn't have each gpio set up as an irq - now can't access set AC on ast2400 (only exists on ast2500) - added ast2600 implementation