Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 01:42:58PM +0300, Marcel Apfelbaum wrote: > On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote: > > Marcel Apfelbaum writes: > > > > > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > > >> This isn't patch review, just a couple of observations and ques

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > >> This isn't patch review, just a couple of observations and questions. > >> > >> Current use of categories, please correct misunderstanding

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: >> This isn't patch review, just a couple of observations and questions. >> >> Current use of categories, please correct misunderstandings: >> >> * A device can have multiple categories. Most (all?) devices

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > Current use of categories, please correct misunderstandings: > > * A device can have multiple categories. Most (all?) devices currently > have exactly one. Al

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Eric Blake
On 08/13/2013 03:57 AM, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > > Should we require devices to have at least one category? If they can be enabled from the command line, yes. (Consider '-device pvpanic, which was NOT available in qemu

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2013 at 11:57:39AM +0200, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > Current use of categories, please correct misunderstandings: > > * A device can have multiple categories. Most (all?) devices currently > have exactly

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Markus Armbruster
This isn't patch review, just a couple of observations and questions. Current use of categories, please correct misunderstandings: * A device can have multiple categories. Most (all?) devices currently have exactly one. * -device help shows categories, like this: name "NAME", bus "BUS"

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 05:17:42PM +0300, Marcel Apfelbaum wrote: > Running qemu with "-device ?" option returns ~145 lines. > It is hard to manage understanding the output. > > Theses patches aim to partially solve the problem by dividing the devices > into logical categories like "Network/Displa

[Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
Running qemu with "-device ?" option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like "Network/Display/..." and sorting them by it. Changes from v3: - fixed a memory leak i