Re: [Qemu-devel] [PATCH v4 0/4] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-01-22 Thread Ard Biesheuvel
On 22 January 2018 at 17:11, Peter Maydell wrote: > On 19 January 2018 at 18:22, Ard Biesheuvel wrote: >> Changes since v3: >> - don't bother with helpers for the SHA3 instructions: they are simple enough >> to be emitted as TCG ops directly >> - rebase onto Richard's pending SVE work > > I've

Re: [Qemu-devel] [PATCH v4 0/4] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-01-22 Thread Peter Maydell
On 19 January 2018 at 18:22, Ard Biesheuvel wrote: > Changes since v3: > - don't bother with helpers for the SHA3 instructions: they are simple enough > to be emitted as TCG ops directly > - rebase onto Richard's pending SVE work I've made a few comments about structural nits but otherwise I th

[Qemu-devel] [PATCH v4 0/4] target-arm: add SHA-3, SM3 and SHA512 instruction support

2018-01-19 Thread Ard Biesheuvel
Changes since v3: - don't bother with helpers for the SHA3 instructions: they are simple enough to be emitted as TCG ops directly - rebase onto Richard's pending SVE work Changes since v2: - fix thinko in big-endian aware handling of 64-bit quantities: this is not needed given that the NEON re