Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-02-21 Thread Stefano Stabellini
On Mon, 13 Feb 2012, Stefano Stabellini wrote: > On Tue, 31 Jan 2012, Stefano Stabellini wrote: > > On Wed, 25 Jan 2012, Stefano Stabellini wrote: > > > Hi all, > > > this is the fourth version of the Xen save/restore patch series. > > > We have been discussing this issue for quite a while on #qemu

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-02-13 Thread Stefano Stabellini
On Tue, 31 Jan 2012, Stefano Stabellini wrote: > On Wed, 25 Jan 2012, Stefano Stabellini wrote: > > Hi all, > > this is the fourth version of the Xen save/restore patch series. > > We have been discussing this issue for quite a while on #qemu and > > qemu-devel: > > > > > > http://marc.info/?l=qe

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-31 Thread Stefano Stabellini
On Wed, 25 Jan 2012, Stefano Stabellini wrote: > Hi all, > this is the fourth version of the Xen save/restore patch series. > We have been discussing this issue for quite a while on #qemu and > qemu-devel: > > > http://marc.info/?l=qemu-devel&m=132346828427314&w=2 > http://marc.info/?l=qemu-devel

[Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-25 Thread Stefano Stabellini
Hi all, this is the fourth version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-devel&m=132346828427314&w=2 http://marc.info/?l=qemu-devel&m=132377734605464&w=2 The principal changes in the this vers

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 09:56 AM, Avi Kivity wrote: On 01/24/2012 03:14 PM, Anthony Liguori wrote: On 01/24/2012 05:10 AM, Avi Kivity wrote: On 01/23/2012 07:18 PM, Anthony Liguori wrote: Generally speaking, RAM is an independent device in most useful cases. Can you give examples? Do you mean a subde

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:14 PM, Anthony Liguori wrote: > On 01/24/2012 05:10 AM, Avi Kivity wrote: >> On 01/23/2012 07:18 PM, Anthony Liguori wrote: >>> Generally speaking, RAM is an independent device in most useful cases. >> >> Can you give examples? Do you mean a subdevice with composition, or a >> rea

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 01:44 PM, Paolo Bonzini wrote: > On 01/24/2012 12:32 PM, Avi Kivity wrote: >>> > Clearing the screen should only write to the RAM at 0xB8000 (and >>> > perhaps 0xA since IIRC it's where text-mode fonts lie). The >>> > option ROM cannot even assume that the main BIOS knows abou

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:25 PM, Anthony Liguori wrote: > >> To my understanding, QXL will break identically on Xen for the same reason: the reset handler assumes it can deal with the VRAM as it likes. >> >> Yes. Some data structures for host<-> guest communication are living >> in device m

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 03:18 PM, Anthony Liguori wrote: > On 01/24/2012 05:13 AM, Avi Kivity wrote: >> On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: >> >> But viewing RAM as just another device, having Xen only restore a >> subset of >> devices should be a reasonable thing to do moving forwar

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 02:00 PM, Stefano Stabellini wrote: > On Tue, 24 Jan 2012, Avi Kivity wrote: > > On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: > > > >>> > > > >>> But viewing RAM as just another device, having Xen only restore a > > > >>> subset of > > > >>> devices should be a reasonable thing to do

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 04:21 AM, Gerd Hoffmann wrote: Hi, We really should view RAM as just another device so I don't like the idea of propagating a global concept of "when RAM is restored" because that treats it specially compared to other devices. But viewing RAM as just another device, having Xen

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 05:13 AM, Avi Kivity wrote: On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: But viewing RAM as just another device, having Xen only restore a subset of devices should be a reasonable thing to do moving forward. I don't think modeling device memory (i.e. vga vram) as something indep

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 05:52 AM, Stefano Stabellini wrote: On Tue, 24 Jan 2012, Avi Kivity wrote: On 01/24/2012 01:27 PM, Paolo Bonzini wrote: On 01/24/2012 12:10 PM, Avi Kivity wrote: But viewing RAM as just another device, having Xen only restore a subset of devices should be a reasonable thing to do

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Anthony Liguori
On 01/24/2012 05:10 AM, Avi Kivity wrote: On 01/23/2012 07:18 PM, Anthony Liguori wrote: Generally speaking, RAM is an independent device in most useful cases. Can you give examples? Do you mean a subdevice with composition, or a really independent device? I expect we'll have one Ram device

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Stefano Stabellini
On Tue, 24 Jan 2012, Avi Kivity wrote: > On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: > > >>> > > >>> But viewing RAM as just another device, having Xen only restore a > > >>> subset of > > >>> devices should be a reasonable thing to do moving forward. > > > > I don't think modeling device memory (

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Stefano Stabellini
On Tue, 24 Jan 2012, Avi Kivity wrote: > On 01/24/2012 01:27 PM, Paolo Bonzini wrote: > > On 01/24/2012 12:10 PM, Avi Kivity wrote: > >>> But viewing RAM as just another device, having Xen only restore a > >>> subset of devices should be a reasonable thing to do moving forward. > >>> The main probl

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Paolo Bonzini
On 01/24/2012 12:32 PM, Avi Kivity wrote: > Clearing the screen should only write to the RAM at 0xB8000 (and > perhaps 0xA since IIRC it's where text-mode fonts lie). The > option ROM cannot even assume that the main BIOS knows about the VESA > framebuffer, can it? Yes, but why should a

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 01:27 PM, Paolo Bonzini wrote: > On 01/24/2012 12:10 PM, Avi Kivity wrote: >>> But viewing RAM as just another device, having Xen only restore a >>> subset of devices should be a reasonable thing to do moving forward. >>> The main problem here I believe is that we have part of the VGA

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Paolo Bonzini
On 01/24/2012 12:10 PM, Avi Kivity wrote: But viewing RAM as just another device, having Xen only restore a subset of devices should be a reasonable thing to do moving forward. The main problem here I believe is that we have part of the VGA Bios functionality in the hardware emulation. Doesn't

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/24/2012 12:21 PM, Gerd Hoffmann wrote: > >>> > >>> But viewing RAM as just another device, having Xen only restore a > >>> subset of > >>> devices should be a reasonable thing to do moving forward. > > I don't think modeling device memory (i.e. vga vram) as something > independent from the de

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Avi Kivity
On 01/23/2012 07:18 PM, Anthony Liguori wrote: > Generally speaking, RAM is an independent device in most useful cases. Can you give examples? Do you mean a subdevice with composition, or a really independent device? > Onboard RAM is a very special case because it's extremely unusual. What's

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-24 Thread Gerd Hoffmann
Hi, >>> We really should view RAM as just another device so I don't like the >>> idea of >>> propagating a global concept of "when RAM is restored" because that >>> treats it >>> specially compared to other devices. >>> >>> But viewing RAM as just another device, having Xen only restore a >>> su

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 11:31 AM, Jan Kiszka wrote: On 2012-01-23 18:18, Anthony Liguori wrote: On 01/23/2012 11:13 AM, Jan Kiszka wrote: To reply to your previous question more clearly: at restore time Qemu on Xen would run in a non-standard scenario; the restore of the RAM happens before QEMU is even s

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Jan Kiszka
On 2012-01-23 18:18, Anthony Liguori wrote: > On 01/23/2012 11:13 AM, Jan Kiszka wrote: > To reply to your previous question more clearly: at restore time Qemu on > Xen would run in a non-standard scenario; the restore of the RAM happens > before QEMU is even started. > > That i

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 11:13 AM, Jan Kiszka wrote: To reply to your previous question more clearly: at restore time Qemu on Xen would run in a non-standard scenario; the restore of the RAM happens before QEMU is even started. That is unfortunate but it would be very hard to change (I can give you more de

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Jan Kiszka
On 2012-01-23 17:16, Stefano Stabellini wrote: > On Mon, 23 Jan 2012, Jan Kiszka wrote: >> On 2012-01-23 15:46, Stefano Stabellini wrote: >>> On Mon, 23 Jan 2012, Jan Kiszka wrote: On 2012-01-23 12:59, Stefano Stabellini wrote: > On Mon, 23 Jan 2012, Jan Kiszka wrote: Or what is t

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 11:05 AM, Stefano Stabellini wrote: On Mon, 23 Jan 2012, Anthony Liguori wrote: However the issue of patch #4, "do not reset videoram on resume", still remains: no matter what parameter I pass to Qemu, if qemu_system_reset is called on resume the videoram is going to be overwritten

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Anthony Liguori wrote: > On 01/23/2012 10:46 AM, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Anthony Liguori wrote: > >> On 01/23/2012 04:47 AM, Stefano Stabellini wrote: > >>> On Fri, 20 Jan 2012, Jan Kiszka wrote: > On 2012-01-20 18:20, Stefano Stabellini wrote: >

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 10:46 AM, Stefano Stabellini wrote: On Mon, 23 Jan 2012, Anthony Liguori wrote: On 01/23/2012 04:47 AM, Stefano Stabellini wrote: On Fri, 20 Jan 2012, Jan Kiszka wrote: On 2012-01-20 18:20, Stefano Stabellini wrote: Hi all, this is the fourth version of the Xen save/restore patc

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Anthony Liguori wrote: > On 01/23/2012 04:47 AM, Stefano Stabellini wrote: > > On Fri, 20 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-20 18:20, Stefano Stabellini wrote: > >>> Hi all, > >>> this is the fourth version of the Xen save/restore patch series. > >>> We have been disc

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 10:16 AM, Stefano Stabellini wrote: On Mon, 23 Jan 2012, Jan Kiszka wrote: On 2012-01-23 15:46, Stefano Stabellini wrote: On Mon, 23 Jan 2012, Jan Kiszka wrote: On 2012-01-23 12:59, Stefano Stabellini wrote: On Mon, 23 Jan 2012, Jan Kiszka wrote: Or what is the ordering of init

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > On 2012-01-23 15:46, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Jan Kiszka wrote: > >> On 2012-01-23 12:59, Stefano Stabellini wrote: > >>> On Mon, 23 Jan 2012, Jan Kiszka wrote: > >> Or what is the ordering > >> of init, RAM restore, and ini

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Anthony Liguori
On 01/23/2012 04:47 AM, Stefano Stabellini wrote: On Fri, 20 Jan 2012, Jan Kiszka wrote: On 2012-01-20 18:20, Stefano Stabellini wrote: Hi all, this is the fourth version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http:/

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Jan Kiszka
On 2012-01-23 15:46, Stefano Stabellini wrote: > On Mon, 23 Jan 2012, Jan Kiszka wrote: >> On 2012-01-23 12:59, Stefano Stabellini wrote: >>> On Mon, 23 Jan 2012, Jan Kiszka wrote: >> Or what is the ordering >> of init, RAM restore, and initial device reset now? > > RAM restore (don

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > On 2012-01-23 12:59, Stefano Stabellini wrote: > > On Mon, 23 Jan 2012, Jan Kiszka wrote: > Or what is the ordering > of init, RAM restore, and initial device reset now? > >>> > >>> RAM restore (done by Xen) > >>> > >>> physmap rebuild (done by xen

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Jan Kiszka
On 2012-01-23 12:59, Stefano Stabellini wrote: > On Mon, 23 Jan 2012, Jan Kiszka wrote: Or what is the ordering of init, RAM restore, and initial device reset now? >>> >>> RAM restore (done by Xen) >>> >>> physmap rebuild (done by xen_hvm_init in qemu) >>> pc_init() >>> qemu_system_reset(

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Mon, 23 Jan 2012, Jan Kiszka wrote: > >> Or what is the ordering > >> of init, RAM restore, and initial device reset now? > > > > RAM restore (done by Xen) > > > > physmap rebuild (done by xen_hvm_init in qemu) > > pc_init() > > qemu_system_reset() > > load_vmstate() > > Hmm, are you sure tha

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Jan Kiszka
On 2012-01-23 11:47, Stefano Stabellini wrote: > On Fri, 20 Jan 2012, Jan Kiszka wrote: >> On 2012-01-20 18:20, Stefano Stabellini wrote: >>> Hi all, >>> this is the fourth version of the Xen save/restore patch series. >>> We have been discussing this issue for quite a while on #qemu and >>> qemu-d

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-23 Thread Stefano Stabellini
On Fri, 20 Jan 2012, Jan Kiszka wrote: > On 2012-01-20 18:20, Stefano Stabellini wrote: > > Hi all, > > this is the fourth version of the Xen save/restore patch series. > > We have been discussing this issue for quite a while on #qemu and > > qemu-devel: > > > > > > http://marc.info/?l=qemu-devel

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-20 Thread Jan Kiszka
On 2012-01-20 18:20, Stefano Stabellini wrote: > Hi all, > this is the fourth version of the Xen save/restore patch series. > We have been discussing this issue for quite a while on #qemu and > qemu-devel: > > > http://marc.info/?l=qemu-devel&m=132346828427314&w=2 > http://marc.info/?l=qemu-devel

[Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-20 Thread Stefano Stabellini
Hi all, this is the fourth version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-devel&m=132346828427314&w=2 http://marc.info/?l=qemu-devel&m=132377734605464&w=2 A few different approaches were propos