Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-21 Thread Zhang, Yang Z
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] I attach a patch that fixes some problems with divider reset and in general simplifies the logic. Even with the patch, however, I still see failures in my test case unfortunately. Probably there are rounding errors

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-21 Thread Paolo Bonzini
Il 22/03/2012 01:23, Zhang, Yang Z ha scritto: Actually, I also see some failures during testing. And most of them are fail to pass the 244us update cycle checking. Since we are in emulation environment, we cannot ensure it always greater than 244us. So I think it should not be a bug. Yes,

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-21 Thread Zhang, Yang Z
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Il 22/03/2012 01:23, Zhang, Yang Z ha scritto: Actually, I also see some failures during testing. And most of them are fail to pass the 244us update cycle checking. Since we are in emulation environment, we

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-21 Thread Paolo Bonzini
Il 22/03/2012 04:03, Zhang, Yang Z ha scritto: Yes, that's fine. But I also see some cases in which the first upgrade cycle after divider reset is not reported. The second, 1.5 seconds after divider reset, is fine. I think your patch can fix it. Right? No. :( It makes it a lot less

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-21 Thread Zhang, Yang Z
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Thursday, March 22, 2012 11:05 AM To: Zhang, Yang Z Cc: qemu-devel@nongnu.org; aligu...@us.ibm.com; k...@vger.kernel.org Subject: Re: [PATCH v4 0/7] RTC: New logic to emulate RTC Il 22/03/2012 04:03, Zhang,

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-20 Thread Paolo Bonzini
Il 19/03/2012 07:13, Zhang, Yang Z ha scritto: Current RTC emulation uses periodic timer(2 timers per second) to update RTC clock. And it will stop CPU staying at deep C-state for long period. Our experience shows the Pkg C6 residency reduced 6% when running 64 idle guest. The following patch

[Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-19 Thread Zhang, Yang Z
Changes in v4: Rebase to latest head. Changing in patch 6: Set the timer to one second earlier before target alarm when AF bit is clear. In version 3, in order to solve the async between UF, AF and UIP, the timer will keep running when UF or AF are clear. This is a little ugly,