As mentioned in my review of Vladimir's v3 of this series [1], I had enough tweaks during my review that it's easier to repost things for another round of discussion, adding some of my patches in between his. I did not include his 13/13 "nbd: Minimal structured read for client", where I had a lot of comments, and suggest that Vladimir is in the best position to rebase that patch on top of this v4 series (post it as a 9/8, if desired).
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02755.html Based-on: <20171015004033.3248-1-ebl...@redhat.com> ([PULL 0/9] NBD patches through 14 Oct) Eric Blake (5): nbd: Include error names in trace messages nbd: Move nbd_errno_to_system_errno() to public header nbd: Expose constants and structs for structured read nbd/server: Include human-readable message in structured errors nbd: Move nbd_read() to common header Vladimir Sementsov-Ogievskiy (3): nbd: Minimal structured read for server nbd/client: refactor nbd_receive_starttls nbd/client: prepare nbd_receive_reply for structured reply include/block/nbd.h | 94 ++++++++++++++++++++++-- nbd/nbd-internal.h | 24 +------ block/nbd-client.c | 8 ++- nbd/client.c | 204 +++++++++++++++++++++++++++++++++------------------- nbd/common.c | 84 ++++++++++++++++++++++ nbd/server.c | 121 ++++++++++++++++++++++++++++--- nbd/trace-events | 15 ++-- 7 files changed, 427 insertions(+), 123 deletions(-) -- 2.13.6