Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-30 Thread Eric Blake
On 11/30/2017 07:04 AM, Vladimir Sementsov-Ogievskiy wrote: Most of conversions looks fine, but it is not simple to prove the correctness, because we start to use internal driver logic on offsets and lengths, not aligned to sectors. The block layer guarantees that it will not pass unaligned dat

Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-30 Thread Vladimir Sementsov-Ogievskiy
Most of conversions looks fine, but it is not simple to prove the correctness, because we start to use internal driver logic on offsets and lengths, not aligned to sectors. And we can't imagine the consequences (at least, I can't and my r-b doesn't give the guarantee) of such change. It is like ta

Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-21 Thread Eric Blake
On 11/21/2017 05:27 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Is it a latest portion of moving to byte-based? All other parts are > already merged? Are you going to update it? (or this version if ok for > review?) This version is okay to review; although it will need a v5 respin once 2.12

Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-21 Thread Vladimir Sementsov-Ogievskiy
Hi! Is it a latest portion of moving to byte-based? All other parts are already merged? Are you going to update it? (or this version if ok for review?) 12.10.2017 21:58, Eric Blake wrote: There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte gr

[Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-10-12 Thread Eric Blake
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byt