Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-20 Thread Richard W.M. Jones
On Sat, Jan 19, 2019 at 11:39:41AM +, Richard W.M. Jones wrote: > > Attached is a NON-working patch to nbdkit-partitioning-plugin which > adds logical partition support. I don't think I've fully understood > how the EBR fields are supposed to be initialized (or else they don't > work how is d

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-19 Thread Richard W.M. Jones
Attached is a NON-working patch to nbdkit-partitioning-plugin which adds logical partition support. I don't think I've fully understood how the EBR fields are supposed to be initialized (or else they don't work how is described in online documentation). This actually causes parted to print an in

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-19 Thread Richard W.M. Jones
On Fri, Jan 18, 2019 at 04:47:42PM -0600, Eric Blake wrote: > It matches the code, but I just learned the code is buggy for anything > larger than 5. According to > http://tldp.org/HOWTO/Large-Disk-HOWTO-13.html, MBR Extended/Logical > partitions form a linked-list, something like: > > MBR:

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Eric Blake
On 1/18/19 7:47 AM, Vladimir Sementsov-Ogievskiy wrote: > > > Only expose MBR partition @var{num}. Understands physical partitions > > 1-4 and logical partitions 5-8. > > I'm afraid, I'm too lazy to sort out these things I don't know, so just > believe. It at least > corresponds to limits in

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Eric Blake
On 1/17/19 1:36 PM, Eric Blake wrote: > I got tired of debugging whether a server was advertising the > correct things during negotiation by inspecting the trace > logs of qemu-io as client - not to mention that without SOME > sort of client tracing particular commands, we can't easily > regression

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Eric Blake
On 1/18/19 7:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> >> Interesting, I don't get it again. Searched in outlook online, I found only >> v2 of it, >> checked spam folder and filters. Magic. Weird indeed. Maybe there's enough @ signs due to .texi content in there that a spam filter somewhere

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
18.01.2019 11:15, Vladimir Sementsov-Ogievskiy wrote: > 17.01.2019 22:36, Eric Blake wrote: >> I got tired of debugging whether a server was advertising the >> correct things during negotiation by inspecting the trace >> logs of qemu-io as client - not to mention that without SOME >> sort of client

Re: [Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-18 Thread Vladimir Sementsov-Ogievskiy
17.01.2019 22:36, Eric Blake wrote: > I got tired of debugging whether a server was advertising the > correct things during negotiation by inspecting the trace > logs of qemu-io as client - not to mention that without SOME > sort of client tracing particular commands, we can't easily > regression t

[Qemu-devel] [PATCH v4 00/21] nbd: add qemu-nbd --list

2019-01-17 Thread Eric Blake
I got tired of debugging whether a server was advertising the correct things during negotiation by inspecting the trace logs of qemu-io as client - not to mention that without SOME sort of client tracing particular commands, we can't easily regression test the server for correct behavior. The fina