Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2012 at 09:31:56AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 04:36:08PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 2

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 04:36:08PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > > The data plan

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 02:57:05PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 02:54:26PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, No

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Paolo Bonzini
> > I don't understand. If memory in the VGA region returns true from > > memory_region_is_ram(), why would there be a problem? > > If you change this memory but you don't update the display. > Never happens with non buggy guests but we should catch and fail if > it does. Actually it _could_ hap

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > The data plane thread needs to map guest physical addresses to host > > > pointers. Norm

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > The data plane thread needs to map guest physical addresses to host > > pointers. Normally this is done with cpu_physical_memory_map() but the > > function ass

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the g

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 02:54:26PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > > The data plan

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > The data plane thread needs to map guest physical addresses to host > > > pointers. Norm

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > The data plane thread needs to map guest physical addresses to host > > pointers. Normally this is done with cpu_physical_memory_map() but the > > function ass

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the g

[Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-22 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.