Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-06-22 Thread Aaron Lindsay
On Jun 22 15:08, Peter Maydell wrote: > On 22 June 2018 at 14:50, Aaron Lindsay wrote: > > On Apr 20 11:17, Peter Maydell wrote: > >> On 17 April 2018 at 21:37, Aaron Lindsay wrote: > >> > pmccntr_read and pmccntr_write contained duplicate code that was already > >> > being handled by

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-06-22 Thread Peter Maydell
On 22 June 2018 at 14:50, Aaron Lindsay wrote: > On Apr 20 11:17, Peter Maydell wrote: >> On 17 April 2018 at 21:37, Aaron Lindsay wrote: >> > pmccntr_read and pmccntr_write contained duplicate code that was already >> > being handled by pmccntr_sync. Consolidate the duplicated code into two >>

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-06-22 Thread Aaron Lindsay
On Apr 20 11:17, Peter Maydell wrote: > On 17 April 2018 at 21:37, Aaron Lindsay wrote: > > pmccntr_read and pmccntr_write contained duplicate code that was already > > being handled by pmccntr_sync. Consolidate the duplicated code into two > > functions: pmccntr_op_start and pmccntr_op_finish.

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-04-20 Thread Peter Maydell
On 17 April 2018 at 21:37, Aaron Lindsay wrote: > pmccntr_read and pmccntr_write contained duplicate code that was already > being handled by pmccntr_sync. Consolidate the duplicated code into two > functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to >

Re: [Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-04-20 Thread Peter Maydell
On 17 April 2018 at 21:37, Aaron Lindsay wrote: > pmccntr_read and pmccntr_write contained duplicate code that was already > being handled by pmccntr_sync. Consolidate the duplicated code into two > functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to >

[Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-04-17 Thread Aaron Lindsay
pmccntr_read and pmccntr_write contained duplicate code that was already being handled by pmccntr_sync. Consolidate the duplicated code into two functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to c15_ccnt in CPUARMState so that we can simultaneously save both the architectural