Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-17 Thread Claudio Fontana
On 16.09.2013 17:07, Richard Henderson wrote: > On 09/16/2013 12:45 AM, Claudio Fontana wrote: default: -tcg_abort(); /* opcode not implemented */ +/* Opcode not implemented. */ +tcg_abort(); } } >> This change above seems unnecessar

Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-16 Thread Richard Henderson
On 09/16/2013 12:45 AM, Claudio Fontana wrote: >> > default: >> > -tcg_abort(); /* opcode not implemented */ >> > +/* Opcode not implemented. */ >> > +tcg_abort(); >> > } >> > } > This change above seems unnecessary. Perhaps qemu doesn't have the same "comments

Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 983a74a..8f19b50 100644 > -

[Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 983a74a..8f19b50 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @