Re: [Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-10-05 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 03:19:44AM +, Gonglei (Arei) wrote: > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Tuesday, October 04, 2016 12:32 AM > > Subject: Re: [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend > > > > On Wed, Sep 28,

Re: [Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-10-04 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Tuesday, October 04, 2016 12:32 AM > Subject: Re: [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend > > On Wed, Sep 28, 2016 at 04:25:43PM +0800, Gonglei wrote: > > +/* Max number of symetrical

Re: [Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 04:25:43PM +0800, Gonglei wrote: > +/* Max number of symetrical sessions */ s/symetrical/symmetric/ But why does the comment say "symetrical" when the constant name MAX_NUM_SESSIONS seems to be a global limit for *all* sessions (not just symmetric)? > +#define

[Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-09-28 Thread Gonglei
The new cryptodev backend named cryptodev-builtin, which realized by QEMU cipher APIS. These APIs can be backed by either nettle or gcrypt. Signed-off-by: Gonglei --- backends/Makefile.objs | 1 + backends/cryptodev-builtin.c | 345