Re: [Qemu-devel] [PATCH v4 06/19] qapi: Better error messages for bad enums

2014-09-24 Thread Markus Armbruster
Eric Blake writes: > On 09/23/2014 08:23 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The previous commit demonstrated that the generator had several >>> flaws with less-than-perfect enums: >>> - an enum that listed the same string twice (or two variant >>> strings that map to the

Re: [Qemu-devel] [PATCH v4 06/19] qapi: Better error messages for bad enums

2014-09-23 Thread Eric Blake
On 09/23/2014 08:23 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The previous commit demonstrated that the generator had several >> flaws with less-than-perfect enums: >> - an enum that listed the same string twice (or two variant >> strings that map to the same C enum) ended up generat

Re: [Qemu-devel] [PATCH v4 06/19] qapi: Better error messages for bad enums

2014-09-23 Thread Markus Armbruster
Eric Blake writes: > The previous commit demonstrated that the generator had several > flaws with less-than-perfect enums: > - an enum that listed the same string twice (or two variant > strings that map to the same C enum) ended up generating an > invalid C enum > - because the generator adds a

[Qemu-devel] [PATCH v4 06/19] qapi: Better error messages for bad enums

2014-09-19 Thread Eric Blake
The previous commit demonstrated that the generator had several flaws with less-than-perfect enums: - an enum that listed the same string twice (or two variant strings that map to the same C enum) ended up generating an invalid C enum - because the generator adds a _MAX terminator to each enum, the