Re: [Qemu-devel] [PATCH v4 07/13] block: vhdx - log parsing, replay, and flush support

2013-08-21 Thread Jeff Cody
On Wed, Aug 21, 2013 at 05:09:30PM +0200, Stefan Hajnoczi wrote: > On Tue, Aug 20, 2013 at 02:01:18AM -0400, Jeff Cody wrote: > > Will require more iterations of review, but here's what I have so far: > Yeah, I assumed it would take a few iterations of review. > > +/* Returns true if the GUID i

Re: [Qemu-devel] [PATCH v4 07/13] block: vhdx - log parsing, replay, and flush support

2013-08-21 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 02:01:18AM -0400, Jeff Cody wrote: Will require more iterations of review, but here's what I have so far: > +/* Returns true if the GUID is zero */ > +static bool vhdx_log_guid_is_zero(MSGUID *guid) > +{ > +int i; > +int ret = 0; > + > +/* If either the log gui

[Qemu-devel] [PATCH v4 07/13] block: vhdx - log parsing, replay, and flush support

2013-08-19 Thread Jeff Cody
This adds support for VHDX v0 logs, as specified in Microsoft's VHDX Specification Format v1.00: https://www.microsoft.com/en-us/download/details.aspx?id=34750 The following support is added: * Log parsing, and validation - validate that an existing log is correct. * Log search - search throug