Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-28 Thread Yan Zhao
On Fri, Jun 28, 2019 at 04:50:30PM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > On Fri, Jun 21, 2019 at 08:31:53AM +0800, Yan Zhao wrote: > > > On Thu, Jun 20, 2019 at 10:37:36PM +0800, Kirti Wankhede wrote: > > > > Added .save_live_pending, .save_live_iterate

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-28 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes > - read data_offset -

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-28 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > On Fri, Jun 21, 2019 at 08:31:53AM +0800, Yan Zhao wrote: > > On Thu, Jun 20, 2019 at 10:37:36PM +0800, Kirti Wankhede wrote: > > > Added .save_live_pending, .save_live_iterate and > > > .save_live_complete_precopy > > > functions. These functions handles

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-24 Thread Yan Zhao
On Fri, Jun 21, 2019 at 08:31:53AM +0800, Yan Zhao wrote: > On Thu, Jun 20, 2019 at 10:37:36PM +0800, Kirti Wankhede wrote: > > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > > functions. These functions handles pre-copy and stop-and-copy phase. > > > > In _SAVING|_

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-24 Thread Kirti Wankhede
>> +static int vfio_save_buffer(QEMUFile *f, VFIODevice *vbasedev) >> +{ >> +VFIOMigration *migration = vbasedev->migration; >> +VFIORegion *region = &migration->region.buffer; >> +uint64_t data_offset = 0, data_size = 0; >> +int ret;

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Alex Williamson
On Sat, 22 Jun 2019 02:35:02 +0530 Kirti Wankhede wrote: > On 6/22/2019 2:02 AM, Alex Williamson wrote: > > On Sat, 22 Jun 2019 01:37:47 +0530 > > Kirti Wankhede wrote: > > > >> On 6/22/2019 1:32 AM, Alex Williamson wrote: > >>> On Sat, 22 Jun 2019 01:08:40 +0530 > >>> Kirti Wankhede wrote

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Kirti Wankhede
On 6/22/2019 2:02 AM, Alex Williamson wrote: > On Sat, 22 Jun 2019 01:37:47 +0530 > Kirti Wankhede wrote: > >> On 6/22/2019 1:32 AM, Alex Williamson wrote: >>> On Sat, 22 Jun 2019 01:08:40 +0530 >>> Kirti Wankhede wrote: >>> On 6/21/2019 8:46 PM, Alex Williamson wrote: > On Fri,

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Alex Williamson
On Sat, 22 Jun 2019 01:37:47 +0530 Kirti Wankhede wrote: > On 6/22/2019 1:32 AM, Alex Williamson wrote: > > On Sat, 22 Jun 2019 01:08:40 +0530 > > Kirti Wankhede wrote: > > > >> On 6/21/2019 8:46 PM, Alex Williamson wrote: > >>> On Fri, 21 Jun 2019 12:08:26 +0530 > >>> Kirti Wankhede wrote

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Kirti Wankhede
On 6/22/2019 1:32 AM, Alex Williamson wrote: > On Sat, 22 Jun 2019 01:08:40 +0530 > Kirti Wankhede wrote: > >> On 6/21/2019 8:46 PM, Alex Williamson wrote: >>> On Fri, 21 Jun 2019 12:08:26 +0530 >>> Kirti Wankhede wrote: >>> On 6/21/2019 12:55 AM, Alex Williamson wrote: > On Thu

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Alex Williamson
On Sat, 22 Jun 2019 01:08:40 +0530 Kirti Wankhede wrote: > On 6/21/2019 8:46 PM, Alex Williamson wrote: > > On Fri, 21 Jun 2019 12:08:26 +0530 > > Kirti Wankhede wrote: > > > >> On 6/21/2019 12:55 AM, Alex Williamson wrote: > >>> On Thu, 20 Jun 2019 20:07:36 +0530 > >>> Kirti Wankhede wrot

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Kirti Wankhede
On 6/21/2019 8:46 PM, Alex Williamson wrote: > On Fri, 21 Jun 2019 12:08:26 +0530 > Kirti Wankhede wrote: > >> On 6/21/2019 12:55 AM, Alex Williamson wrote: >>> On Thu, 20 Jun 2019 20:07:36 +0530 >>> Kirti Wankhede wrote: >>> Added .save_live_pending, .save_live_iterate and .sav

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-21 Thread Alex Williamson
On Fri, 21 Jun 2019 12:08:26 +0530 Kirti Wankhede wrote: > On 6/21/2019 12:55 AM, Alex Williamson wrote: > > On Thu, 20 Jun 2019 20:07:36 +0530 > > Kirti Wankhede wrote: > > > >> Added .save_live_pending, .save_live_iterate and > >> .save_live_complete_precopy > >> functions. These functions

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-20 Thread Kirti Wankhede
On 6/21/2019 12:55 AM, Alex Williamson wrote: > On Thu, 20 Jun 2019 20:07:36 +0530 > Kirti Wankhede wrote: > >> Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy >> functions. These functions handles pre-copy and stop-and-copy phase. >> >> In _SAVING|_RUNNING device

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-20 Thread Yan Zhao
On Thu, Jun 20, 2019 at 10:37:36PM +0800, Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes > - r

Re: [Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-20 Thread Alex Williamson
On Thu, 20 Jun 2019 20:07:36 +0530 Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes > - read d

[Qemu-devel] [PATCH v4 08/13] vfio: Add save state functions to SaveVMHandlers

2019-06-20 Thread Kirti Wankhede
Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy phase: - read pending_bytes - read data_offset - indicates kernel driver to write data to staging buffer