Re: [Qemu-devel] [PATCH v4 09/10] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-09-27 Thread Vladimir Sementsov-Ogievskiy
27 сент. 2019 г. 21:59 пользователь John Snow написал: On 9/27/19 3:52 AM, Vladimir Sementsov-Ogievskiy wrote: > 27.09.2019 2:21, John Snow wrote: >> >> >> On 8/7/19 10:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> - Correct check for write access to file child, and in correct place >>>(o

Re: [Qemu-devel] [PATCH v4 09/10] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-09-27 Thread John Snow
On 9/27/19 3:52 AM, Vladimir Sementsov-Ogievskiy wrote: > 27.09.2019 2:21, John Snow wrote: >> >> >> On 8/7/19 10:12 AM, Vladimir Sementsov-Ogievskiy wrote: >>> - Correct check for write access to file child, and in correct place >>>(only if we want to write). >>> - Support reopen rw -> rw (

Re: [Qemu-devel] [PATCH v4 09/10] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-09-27 Thread Vladimir Sementsov-Ogievskiy
27.09.2019 2:21, John Snow wrote: > > > On 8/7/19 10:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> - Correct check for write access to file child, and in correct place >>(only if we want to write). >> - Support reopen rw -> rw (which will be used in following commit), >>for example, !bdrv

Re: [Qemu-devel] [PATCH v4 09/10] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-09-26 Thread John Snow
On 8/7/19 10:12 AM, Vladimir Sementsov-Ogievskiy wrote: > - Correct check for write access to file child, and in correct place > (only if we want to write). > - Support reopen rw -> rw (which will be used in following commit), > for example, !bdrv_dirty_bitmap_readonly() is not a corruption

[Qemu-devel] [PATCH v4 09/10] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw

2019-08-07 Thread Vladimir Sementsov-Ogievskiy
- Correct check for write access to file child, and in correct place (only if we want to write). - Support reopen rw -> rw (which will be used in following commit), for example, !bdrv_dirty_bitmap_readonly() is not a corruption if bitmap is marked IN_USE in the image. - Consider unexpected bi