Re: [Qemu-devel] [PATCH v4 09/10] tcg: Clean up direct block chaining safety checks

2016-04-21 Thread Alex Bennée
Sergey Fedorov writes: > On 21/04/16 16:18, Alex Bennée wrote: >> Sergey Fedorov writes: >>> diff --git a/cpu-exec.c b/cpu-exec.c >>> index bbfcbfb54385..065cc9159477 100644 >>> --- a/cpu-exec.c >>> +++ b/cpu-exec.c >>> @@ -508,11 +508,8 @@ int cpu_exec(CPUState *cpu) >>> n

Re: [Qemu-devel] [PATCH v4 09/10] tcg: Clean up direct block chaining safety checks

2016-04-21 Thread Sergey Fedorov
On 21/04/16 16:18, Alex Bennée wrote: > Sergey Fedorov writes: >> diff --git a/cpu-exec.c b/cpu-exec.c >> index bbfcbfb54385..065cc9159477 100644 >> --- a/cpu-exec.c >> +++ b/cpu-exec.c >> @@ -508,11 +508,8 @@ int cpu_exec(CPUState *cpu) >> next_tb = 0; >>

Re: [Qemu-devel] [PATCH v4 09/10] tcg: Clean up direct block chaining safety checks

2016-04-21 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > We don't take care of direct jumps when address mapping changes. Thus we > must be sure to generate direct jumps so that they always keep valid > even if address mapping changes. Luckily, we can only allow to execute a > TB if it was generated f

[Qemu-devel] [PATCH v4 09/10] tcg: Clean up direct block chaining safety checks

2016-04-20 Thread Sergey Fedorov
From: Sergey Fedorov We don't take care of direct jumps when address mapping changes. Thus we must be sure to generate direct jumps so that they always keep valid even if address mapping changes. Luckily, we can only allow to execute a TB if it was generated from the pages which match with curren