On Wed, Jan 09, 2013 at 01:36:50AM +0100, Andreas Färber wrote:
> > I also removed all accesses to internals.
>
> qdev->parent_bus is not supposed to be accessed either, there is
> qdev_get_parent_bus() as accessor function.
Yeah, that one I had also changed :)
(I didn't find any accessor for q
Am 08.01.2013 16:57, schrieb Alberto Garcia:
> On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:
>
>> IPACK_DEVICE()
>>
>> You have them defined in the header, please use them consistently.
>>
>> Also, please avoid accessing internals like &s->bus.qbus
>> (BUS(s->bus)) or &s->dev.qde
On Tue, Jan 08, 2013 at 05:22:35PM +0100, Andreas Färber wrote:
> > Tell me if there's anything else I should change, else I can post
> > the new patches.
>
> Haven't looked at the latest 2/2 patch yet, same might apply there.
> Otherwise no issues spotted in 1/2.
Yes, I updated both patches. Sh
Am 08.01.2013 16:57, schrieb Alberto Garcia:
> On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:
>
>> IPACK_DEVICE()
>>
>> You have them defined in the header, please use them consistently.
>>
>> Also, please avoid accessing internals like &s->bus.qbus
>> (BUS(s->bus)) or &s->dev.qde
On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:
> IPACK_DEVICE()
>
> You have them defined in the header, please use them consistently.
>
> Also, please avoid accessing internals like &s->bus.qbus
> (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)).
Ok, I'm using all the defined ma
Am 08.01.2013 02:10, schrieb Alberto Garcia:
> The TPCI200 is a PCI board that supports up to 4 IndustryPack modules.
>
> A new bus type called 'IndustryPack' has been created so any
> compatible module can be attached to this board.
>
> Signed-off-by: Alberto Garcia
> ---
> default-configs/pci
The TPCI200 is a PCI board that supports up to 4 IndustryPack modules.
A new bus type called 'IndustryPack' has been created so any
compatible module can be attached to this board.
Signed-off-by: Alberto Garcia
---
default-configs/pci.mak |1 +
hw/Makefile.objs|3 +
hw/ipack.c
