Re: [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Paulina Szubarczyk
On 08/04/2016 11:38 AM, Wei Liu wrote: The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: In a linux part an ioctl(gntdev, IOCTL

Re: [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-04 Thread Wei Liu
The code looks ok. I have two minor suggestions below. I would suggest changing the subject line to: libs/gnttab: introduce grant copy interface On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is

[Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs.

2016-08-02 Thread Paulina Szubarczyk
In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) system call is invoked. In mini-os the operation is yet not implemented. For the OSs that does not implement gnttab the call of the grant copy operation causes abort. Signed-off-by: Paulina Szubarczyk --- Changes since v3: - revert to