Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-31 Thread Dou Liyang
Hi Eduardo, At 08/31/2017 06:38 PM, Dou Liyang wrote: Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-31 Thread Dou Liyang
Hi Eduardo, [...] +continue; } Now the nodes will be out of order, if node 0 has no RAM. Why? Because the code parsed the other node with RAM first, then parsed the node 0. Why not implement this in the same way the PCI 4GB hole is already implemented. e.g.:

Re: [Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-30 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 11:24:09AM +0800, Dou Liyang wrote: > Currently, Using the fisrt node without memory on the machine makes > QEMU unhappy. With this example command line: > ... \ > -m 1024M,slots=4,maxmem=32G \ > -numa node,nodeid=0 \ > -numa node,mem=1024M,nodeid=1 \ > -numa

[Qemu-devel] [PATCH v4 1/2] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-21 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration