Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-23 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 11:17:16AM +0300, Chrysostomos Nanakos wrote: > On 06/20/2014 05:33 PM, Stefan Hajnoczi wrote: > >On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: > > > >>+if (!segreq->failed) { > >>+reqdata->aio_cb->r

Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-23 Thread Chrysostomos Nanakos
On 06/20/2014 05:33 PM, Stefan Hajnoczi wrote: On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: +typedef struct BDRVArchipelagoState { +int fds[2]; +int qemu_aio_count; This field is never used. It's increment and decremented but nothing ever checks the value. It

Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-20 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: > +typedef struct BDRVArchipelagoState { > +int fds[2]; > +int qemu_aio_count; This field is never used. It's increment and decremented but nothing ever checks the value. It can be dropped. > +int event_reader_pos

[Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-19 Thread Chrysostomos Nanakos
VM Image on Archipelago volume is specified like this: file=archipelago:[/mport=[:vport=]] or file.driver=archipelago,file.volume=[,file.mport=[, file.vport=]] 'archipelago' is the protocol. 'mport' is the port number on which mapperd is listening. This is optional and if not specified, QEMU w