Re: [Qemu-devel] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-07 Thread David Gibson
On Tue, Sep 06, 2016 at 03:17:55PM +0200, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > v4: > - add this patch in the series to change all strtoXX() in qtest.c > > qtest.c | 49 ++--- > 1 file changed, 26 in

Re: [Qemu-devel] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-06 Thread Greg Kurz
On Tue, 6 Sep 2016 20:17:00 +0200 Laurent Vivier wrote: > On 06/09/2016 17:55, Greg Kurz wrote: > > On Tue, 6 Sep 2016 15:17:55 +0200 > > Laurent Vivier wrote: > > > >> Signed-off-by: Laurent Vivier > >> --- > > > > The patch also adds error checking and assertions. Maybe worth to be >

Re: [Qemu-devel] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-06 Thread Laurent Vivier
On 06/09/2016 17:55, Greg Kurz wrote: > On Tue, 6 Sep 2016 15:17:55 +0200 > Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier >> --- > > The patch also adds error checking and assertions. Maybe worth to be mentioned > in the changelog... In case of a new version of the patch, I will.

Re: [Qemu-devel] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-06 Thread Greg Kurz
On Tue, 6 Sep 2016 15:17:55 +0200 Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- The patch also adds error checking and assertions. Maybe worth to be mentioned in the changelog... > v4: > - add this patch in the series to change all strtoXX() in qtest.c > > qtest.c | 49 +++

[Qemu-devel] [PATCH v4 1/3] qtest: replace strtoXX() by qemu_strtoXX()

2016-09-06 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- v4: - add this patch in the series to change all strtoXX() in qtest.c qtest.c | 49 ++--- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/qtest.c b/qtest.c index da4826c..4c94708 100644 --- a/qtest.c ++