Re: [Qemu-devel] [PATCH v4 1/4] qemu-io: Don't die on second open

2017-06-05 Thread John Snow
On 06/05/2017 04:38 PM, Eric Blake wrote: > Most callback commands in qemu-io return 0 to keep the interpreter > loop running, or 1 to quit immediately. However, open_f() just > passed through the return value of openfile(), which has different > semantics of returning 0 if a file was opened, or

[Qemu-devel] [PATCH v4 1/4] qemu-io: Don't die on second open

2017-06-05 Thread Eric Blake
Most callback commands in qemu-io return 0 to keep the interpreter loop running, or 1 to quit immediately. However, open_f() just passed through the return value of openfile(), which has different semantics of returning 0 if a file was opened, or 1 on any failure. As a result of mixing the return