Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code

2017-05-11 Thread Pradeep Jagadeesh
On 5/10/2017 9:48 PM, Eric Blake wrote: On 05/10/2017 10:27 AM, Pradeep Jagadeesh wrote: Isn't it a bit overkill to introduce a new file for a single function ? Maybe you could simply move this to util/throttle.c ? OK, but I will add one more function later patch. Still do you think better

Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code

2017-05-10 Thread Eric Blake
On 05/10/2017 10:27 AM, Pradeep Jagadeesh wrote: >> >> Isn't it a bit overkill to introduce a new file for a single function ? >> Maybe you could simply move this to util/throttle.c ? >> > OK, but I will add one more function later patch. Still do you think > better to move to util/thottle.c? As

Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code

2017-05-10 Thread Pradeep Jagadeesh
On 5/10/2017 4:12 PM, Greg Kurz wrote: On Wed, 10 May 2017 04:41:20 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh ---

Re: [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code

2017-05-10 Thread Greg Kurz
On Wed, 10 May 2017 04:41:20 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate throttle code that was present in > block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- > blockdev.c

[Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code

2017-05-10 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 44 +-- fsdev/qemu-fsdev-throttle.c | 43