Re: [Qemu-devel] [PATCH v4 1/6] target-arm: Add CNTVOFF_EL2

2015-06-15 Thread Peter Maydell
On 15 June 2015 at 01:52, Edgar E. Iglesias wrote: > On Fri, Jun 12, 2015 at 05:44:24PM +0100, Peter Maydell wrote: >> On 5 June 2015 at 11:33, Edgar E. Iglesias wrote: >> > +int istatus = (int64_t) (count - offset - gt->cval) >= 0; >> >> This is wrong. Consider the case where: >> count

Re: [Qemu-devel] [PATCH v4 1/6] target-arm: Add CNTVOFF_EL2

2015-06-14 Thread Edgar E. Iglesias
On Fri, Jun 12, 2015 at 05:44:24PM +0100, Peter Maydell wrote: > On 5 June 2015 at 11:33, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Adds support for the virtual timer offset controlled by EL2. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > > --- a/target-arm/helper.c

Re: [Qemu-devel] [PATCH v4 1/6] target-arm: Add CNTVOFF_EL2

2015-06-12 Thread Peter Maydell
On 5 June 2015 at 11:33, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Adds support for the virtual timer offset controlled by EL2. > > Signed-off-by: Edgar E. Iglesias > --- > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -1208,9 +1208,20 @@ static void gt_recalc_timer(

[Qemu-devel] [PATCH v4 1/6] target-arm: Add CNTVOFF_EL2

2015-06-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Adds support for the virtual timer offset controlled by EL2. Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 1 + target-arm/helper.c | 58 ++--- 2 files changed, 52 insertions(+), 7 deletions(-) diff --git