Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-02-01 Thread Michael S. Tsirkin
On Wed, Feb 01, 2017 at 12:46:47PM +0100, Igor Mammedov wrote: > On Tue, 31 Jan 2017 23:39:44 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 31, 2017 at 10:51:02AM +0100, Igor Mammedov wrote: > > > On Mon, 30 Jan 2017 22:28:41 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fr

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-02-01 Thread Igor Mammedov
On Tue, 31 Jan 2017 23:39:44 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 31, 2017 at 10:51:02AM +0100, Igor Mammedov wrote: > > On Mon, 30 Jan 2017 22:28:41 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jan 27, 2017 at 10:43:13AM -0500, Kevin O'Connor wrote: > > > > On Fri, Ja

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-31 Thread Michael S. Tsirkin
On Tue, Jan 31, 2017 at 10:51:02AM +0100, Igor Mammedov wrote: > On Mon, 30 Jan 2017 22:28:41 +0200 > "Michael S. Tsirkin" wrote: > > > On Fri, Jan 27, 2017 at 10:43:13AM -0500, Kevin O'Connor wrote: > > > On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: > > > > On 01/27/17 15:18,

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-31 Thread Igor Mammedov
On Mon, 30 Jan 2017 22:28:41 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jan 27, 2017 at 10:43:13AM -0500, Kevin O'Connor wrote: > > On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: > > > On 01/27/17 15:18, Kevin O'Connor wrote: > > > > If an offset is going to be added, shouldn'

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-30 Thread Michael S. Tsirkin
On Fri, Jan 27, 2017 at 10:43:13AM -0500, Kevin O'Connor wrote: > On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: > > On 01/27/17 15:18, Kevin O'Connor wrote: > > > If an offset is going to be added, shouldn't both a source offset and > > > destination offset be used? > > > > > >

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-30 Thread Laszlo Ersek
On 01/27/17 19:19, Ben Warren wrote: > >> On Jan 27, 2017, at 8:12 AM, Laszlo Ersek > > wrote: >> >> On 01/27/17 16:43, Kevin O'Connor wrote: >>> On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: On 01/27/17 15:18, Kevin O'Connor wrote: > If an offset

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Ben Warren
> On Jan 27, 2017, at 8:12 AM, Laszlo Ersek wrote: > > On 01/27/17 16:43, Kevin O'Connor wrote: >> On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: >>> On 01/27/17 15:18, Kevin O'Connor wrote: If an offset is going to be added, shouldn't both a source offset and destinatio

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Kevin O'Connor
On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: > On 01/27/17 15:18, Kevin O'Connor wrote: > > If an offset is going to be added, shouldn't both a source offset and > > destination offset be used? > > > > /* > > * COMMAND_WRITE_POINTER - update a writeable file named

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Laszlo Ersek
On 01/27/17 16:43, Kevin O'Connor wrote: > On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: >> On 01/27/17 15:18, Kevin O'Connor wrote: >>> If an offset is going to be added, shouldn't both a source offset and >>> destination offset be used? >>> >>> /* >>> * COMMAND_WR

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Laszlo Ersek
On 01/27/17 15:18, Kevin O'Connor wrote: > On Thu, Jan 26, 2017 at 08:59:04PM +0200, Michael S. Tsirkin wrote: >> On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote: >>> On 01/26/17 19:15, Michael S. Tsirkin wrote: On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: > O

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Kevin O'Connor
On Thu, Jan 26, 2017 at 08:59:04PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote: > > On 01/26/17 19:15, Michael S. Tsirkin wrote: > > > On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: > > >> On 01/26/17 16:20, Michael S. Tsirkin wrote

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Laszlo Ersek
On 01/26/17 19:59, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote: >> On 01/26/17 19:15, Michael S. Tsirkin wrote: >>> On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: On 01/26/17 16:20, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2017

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote: > On 01/26/17 19:15, Michael S. Tsirkin wrote: > > On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: > >> On 01/26/17 16:20, Michael S. Tsirkin wrote: > >>> On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote: > >> >

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Laszlo Ersek
On 01/26/17 19:15, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: >> On 01/26/17 16:20, Michael S. Tsirkin wrote: >>> On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote: >> But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wid

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote: > On 01/26/17 16:20, Michael S. Tsirkin wrote: > > On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote: > > >> But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wide. > > > > > > What is COMMAND_ALLOCATE_RETURN

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Laszlo Ersek
On 01/26/17 16:20, Michael S. Tsirkin wrote: > On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote: >> But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wide. > > > What is COMMAND_ALLOCATE_RETURN_ADDR? I'm only familiar with > COMMAND_ALLOCATE. It's a new command being

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Michael S. Tsirkin
On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote: > On 01/25/17 19:35, Michael S. Tsirkin wrote: > > On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: > >> Hi Laszlo, > >> > >> > >> On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: > >> > >> Hi Ben, > >> > >> sorry

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-26 Thread Laszlo Ersek
On 01/26/17 06:35, Ben Warren wrote: > >> On Jan 25, 2017, at 4:48 PM, Laszlo Ersek > > wrote: >> >> On 01/25/17 19:35, Michael S. Tsirkin wrote: >>> On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: Hi Laszlo, On Jan 24, 2017, at 7:55 PM,

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
> On Jan 25, 2017, at 4:48 PM, Laszlo Ersek wrote: > > On 01/25/17 19:35, Michael S. Tsirkin wrote: >> On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: >>> Hi Laszlo, >>> >>> >>>On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: >>> >>>Hi Ben, >>> >>>sorry about being l

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Laszlo Ersek
On 01/25/17 19:35, Michael S. Tsirkin wrote: > On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: >> Hi Laszlo, >> >> >> On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: >> >> Hi Ben, >> >> sorry about being late to reviewing this series. I hope I can now spend >> more tim

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Michael S. Tsirkin
On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: > Hi Laszlo, > > > On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: > > Hi Ben, > > sorry about being late to reviewing this series. I hope I can now spend > more time on it. > > - Please do not try to address my

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
Hi Laszlo, > On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote: > > Hi Ben, > > sorry about being late to reviewing this series. I hope I can now spend > more time on it. > > - Please do not try to address my comments immediately. It's very > possible (even likely) that Igor, MST and myself coul

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-24 Thread Laszlo Ersek
Hi Ben, sorry about being late to reviewing this series. I hope I can now spend more time on it. - Please do not try to address my comments immediately. It's very possible (even likely) that Igor, MST and myself could have different opinions on things, so first please await agreement between your

[Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-24 Thread ben
From: Ben Warren This is initially used to patch a 64-bit address into the VM Generation ID SSDT Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 4 2 files changed, 32 insertions(+) diff --git a/hw/acpi/aml-build