Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-19 Thread Alex Bennée
Peter Maydell writes: > On 6 February 2018 at 16:48, Alex Bennée wrote: >> We can now add float16_mul and use the common decompose and >> canonicalize functions to have a single implementation for >> float16/32/64 versions. >> >> Signed-off-by: Alex Bennée >> Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-13 Thread Richard Henderson
On 02/13/2018 07:20 AM, Peter Maydell wrote: >> +static FloatParts mul_floats(FloatParts a, FloatParts b, float_status *s) >> +{ >> +bool sign = a.sign ^ b.sign; >> + >> +if (a.cls == float_class_normal && b.cls == float_class_normal) { >> +uint64_t hi, lo; >> +int exp = a.e

Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-13 Thread Peter Maydell
On 6 February 2018 at 16:48, Alex Bennée wrote: > We can now add float16_mul and use the common decompose and > canonicalize functions to have a single implementation for > float16/32/64 versions. > > Signed-off-by: Alex Bennée > Signed-off-by: Richard Henderson > > --- > v3 > +/* > + * Returns

[Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-06 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- v3 - mul compile fixes for new names - remove duplicate s-o-b - more explicit inf