Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges

2012-07-30 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/alpha_typhoon.c |4 ++-- hw/dec_pci.c |2 +-

Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges

2012-07-30 Thread Andreas Färber
Am 30.07.2012 18:07, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/alpha_typhoon.c

Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges

2012-07-29 Thread Michael S. Tsirkin
On Thu, Jul 26, 2012 at 02:28:32PM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de I already said I don't see the point of this

Re: [Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges

2012-07-29 Thread Andreas Färber
Am 29.07.2012 14:22, schrieb Michael S. Tsirkin: On Thu, Jul 26, 2012 at 02:28:32PM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH v4 14/18] pci: Tidy up PCI host bridges

2012-07-26 Thread Andreas Färber
Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/alpha_typhoon.c |4 ++-- hw/dec_pci.c |2 +- hw/grackle_pci.c |2 +- hw/gt64xxx.c |