Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:54 AM, Hu Tao wrote: > diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c > index 380073a..1f3b851 100644 > --- a/hw/virtio-scsi.c > +++ b/hw/virtio-scsi.c > @@ -239,7 +239,7 @@ static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, > VirtQueue *vq) > > static void virtio_scsi_

Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:54 AM, Hu Tao wrote: > should be req->req.tmf->lun here and elsewhere in this function? Yes, good catch! Paolo

Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-23 Thread Hu Tao
On Wed, Feb 22, 2012 at 03:33:52PM +0100, Paolo Bonzini wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- > hw/virtio-scsi.c | 134 ++--- > 1 files changed, 126 insertions(+), 8 deletions(-) > > diff --git a/hw/virtio-scs

[Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-22 Thread Paolo Bonzini
Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 134 ++--- 1 files changed, 126 insertions(+), 8 deletions(-) diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index f4eb8c7..380073a 100644 --- a/hw/virtio-scsi.c +