Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-25 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote: > > On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: > > >From: "Dr. David Alan Gilbert" > [snip] > > > >+case MIG_RPCOMM_ACK: > > >+tmp32 = be32_to_cpup(

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-19 Thread David Gibson
On Wed, Nov 19, 2014 at 05:06:50PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Mon, Nov 03, 2014 at 01:22:45PM +, Dr. David Alan Gilbert wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Fri, Oct 03, 2014 at 06:47:2

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-19 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Mon, Nov 03, 2014 at 01:22:45PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-17 Thread David Gibson
On Mon, Nov 03, 2014 at 01:22:45PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Open a return path, and handle mess

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-03 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Open a return path, and handle messages that are received upon it. > > > > Signed-off-by: Dr. David Alan Gilbert > > [s

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Open a return path, and handle messages that are received upon it. > > Signed-off-by: Dr. David Alan Gilbert [snip] > @@ -414,6 +448,11 @@ static void migrate_fd_cancel(MigrationS

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-02 Thread David Gibson
On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote: > On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" [snip] > >+case MIG_RPCOMM_ACK: > >+tmp32 = be32_to_cpup((uint32_t *)buf); > >+DPRINTF("RP: Received ACK 0x%x",

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-24 Thread Paolo Bonzini
On 10/23/2014 08:00 PM, Dr. David Alan Gilbert wrote: >>> > > +static bool migration_already_active(MigrationState *ms) >>> > > +{ >>> > > +switch (ms->state) { >>> > > +case MIG_STATE_ACTIVE: >>> > > +case MIG_STATE_SETUP: >>> > > +return true; >>> > > + >>> > > +default:

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +/* Source side RP state */ > > +struct MigrationRetPathState { > > +uint32_t latest_ack; > > +QemuThreadrp_thread; > > +bool error; > > Should the QemuFil

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread zhanghailiang
On 2014/10/16 16:35, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: +case MIG_RPCOMM_ACK: +tmp32 = be32_to_cpup((uint32_t *)buf); +DPRINTF("RP: Received ACK 0x%x", tmp32); +atomic_xchg(&ms->rp_state.latest_ack, t

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >+case MIG_RPCOMM_ACK: > >+tmp32 = be32_to_cpup((uint32_t *)buf); > >+DPRINTF("RP: Received ACK 0x%x", tmp32); > >+atomic_xchg(&ms->rp_state.latest_ack, tmp32); > > I didn't see *ms->rp_state.lat

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread zhanghailiang
On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 10 +++ migration.c | 181 ++

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-04 Thread Paolo Bonzini
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > +/* Source side RP state */ > +struct MigrationRetPathState { > +uint32_t latest_ack; > +QemuThreadrp_thread; > +bool error; Should the QemuFile be in here? > +}; > + Also please do not abbrev words, an

[Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 10 +++ migration.c | 181 +- 2 files changed, 190 insertions(+