Re: [Qemu-devel] [PATCH v4 18/29] target-ppc: Refactor class init for POWER7/8

2014-06-04 Thread Tom Musta
On 6/3/2014 9:09 PM, Alexey Kardashevskiy wrote: > How so? > > gen_spr_book3s_pmu_xxx add PCM1..6, gen_spr_970_pmu_xxx add PMC7-8. > > Since patch #4, 970/p5+ do not use old PMU SPRs. > Alexey: You are correct ... I misread the code. Reviewed-by: Tom Musta

Re: [Qemu-devel] [PATCH v4 18/29] target-ppc: Refactor class init for POWER7/8

2014-06-03 Thread Alexey Kardashevskiy
On 06/04/2014 02:57 AM, Tom Musta wrote: > On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote: >> This extends init_proc_book3s_64 to support POWER7 and POWER8. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v4: >> * added g_assert_not_reached() to default path to catch errors earlie

Re: [Qemu-devel] [PATCH v4 18/29] target-ppc: Refactor class init for POWER7/8

2014-06-03 Thread Tom Musta
On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote: > This extends init_proc_book3s_64 to support POWER7 and POWER8. > > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v4: > * added g_assert_not_reached() to default path to catch errors earlier > --- > target-ppc/translate_init.c | 100 > +

[Qemu-devel] [PATCH v4 18/29] target-ppc: Refactor class init for POWER7/8

2014-06-03 Thread Alexey Kardashevskiy
This extends init_proc_book3s_64 to support POWER7 and POWER8. Signed-off-by: Alexey Kardashevskiy --- Changes: v4: * added g_assert_not_reached() to default path to catch errors earlier --- target-ppc/translate_init.c | 100 +++- 1 file changed, 61 insert