Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-12-11 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Nov 19, 2014 at 05:50:11PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-11-20 Thread David Gibson
On Wed, Nov 19, 2014 at 05:50:11PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Postcopy needs to have two migratio

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-11-19 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Postcopy needs to have two migration streams loading concurrently; > > one from memory (with the device state) and the oth

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy needs to have two migration streams loading concurrently; > one from memory (with the device state) and the other from the fd > with the memory transactions. > > Split the

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-10-07 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto: > > > >>> > > +if (exitcode & LOADVM_EXITCODE_QUITPARENT) { > >>> > > +DPRINTF("loadvm_handlers_state_main: End of loop with > >>> > > QUITPARENT"); > >>> > > +exitcode &= ~L

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-10-07 Thread Paolo Bonzini
Il 07/10/2014 10:58, Dr. David Alan Gilbert ha scritto: > >>> > > +if (exitcode & LOADVM_EXITCODE_QUITPARENT) { >>> > > +DPRINTF("loadvm_handlers_state_main: End of loop with >>> > > QUITPARENT"); >>> > > +exitcode &= ~LOADVM_EXITCODE_QUITPARENT; >>> > > +exitcode &= L

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-10-07 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > > > +/* These are ORable flags */ > > ... make them an "enum". OK, will do - I'd generally tended to avoid using enum for things that were ORable where the combinations weren't thems

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-10-04 Thread Paolo Bonzini
Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: > > +/* These are ORable flags */ ... make them an "enum". > +const int LOADVM_EXITCODE_QUITLOOP = 1; > +const int LOADVM_EXITCODE_QUITPARENT = 2; LOADVM_QUIT_ALL, LOADVM_QUIT respectively? > +const int LOADVM_EXITCODE_KEEP

[Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-10-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions. Split the core of qemu_loadvm_state out so we can use it for both. Allow the inner loadvm loop to qui